Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add c16:uniqueId to several chart complex types #1767

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

tomjebo
Copy link
Collaborator

@tomjebo tomjebo commented Aug 1, 2024

Classes for the following complex types receive the DocumentFormat.OpenXml.Office2016.Drawing.Charts.UniqueID (c16:uniqueId) extension child:
CT_DLbl, CT_LineSer, CT_ScatterSer, CT_RadarSer, CT_BarSer, CT_AreaSer, CT_PieSer, CT_BubbleSer, CT_SurfaceSer

@tomjebo tomjebo marked this pull request as draft August 1, 2024 20:48
@tomjebo
Copy link
Collaborator Author

tomjebo commented Aug 1, 2024

fixes #1762

@tomjebo tomjebo self-assigned this Aug 1, 2024
@tomjebo
Copy link
Collaborator Author

tomjebo commented Aug 1, 2024

UPDATE: moved this todo to:

as it doesn't relate the fix for #1762

TODO:
need to obsolete pictureOptions from CT_LineSer, CT_RadarSer, CT_PieSer, CT_BubbleSer and CT_SurfaceSer
need to obsolete bubble3D from CT_SurfaceSer

these children have been removed in the latest Office schemas.

Copy link

github-actions bot commented Aug 1, 2024

Test Results

    70 files  ±0      70 suites  ±0   57m 30s ⏱️ - 1m 25s
 2 033 tests ±0   2 030 ✅ ±0   3 💤 ±0  0 ❌ ±0 
32 322 runs  ±0  32 286 ✅ ±0  36 💤 ±0  0 ❌ ±0 

Results for commit ad14081. ± Comparison against base commit 522f9f3.

@tomjebo tomjebo marked this pull request as ready for review August 1, 2024 23:26
Copy link
Collaborator

@mikeebowen mikeebowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomjebo tomjebo enabled auto-merge (squash) August 1, 2024 23:30
@tomjebo tomjebo modified the milestones: v3.1.1, v3.2.0 Aug 1, 2024
@tomjebo tomjebo merged commit afc9bdf into dotnet:main Aug 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants