1846 server mqttserverstopasync doesnt indicate correct reason #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkr1011
deleted the
1846-server-mqttserverstopasync-doesnt-indicate-correct-reason
branch
JanEggers
reviewed
Dec 3, 2023
| services.TryAddSingleton(new MqttFactory()); | ||
|
|
||
| services.AddSingleton<MqttHostedServer>(); | ||
| services.AddHostedService<MqttHostedServer>(); |
There was a problem hiding this comment.
@chkr1011 this is bugged you will have 2 instances of MqttHostedServer. one when resolving the singleton and one IHostedService instance. use AddHostedService(c => c.GetRequiredService<MqttHostedServer>())
There was a problem hiding this comment.
Thanks @JanEggers for having a look at the change. Please see PR #1892 and let me know if it is correct now. I basically reverted the lines so that it is exactly the same as it was before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new overloads for the server so that the user can send custom user properties or reason codes when stopping the server.
It also fixes the issue that the default used reason code was not correct when stopping the server.
A new property is also added to the server which allows to stop accepting new connections while the server is still running.