-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit state reentry from dynamic transitions. #571
Permit state reentry from dynamic transitions. #571
Conversation
* Make FireAsync_TriggerWithMoreThanThreeParameters unit test culturally invariant. Otherwise it fails on some system locales.
|
||
Assert.Equal(expectedParam, actualParam); | ||
} | ||
|
||
[Fact] | ||
public async Task FireAsync_TriggerWithMoreThanThreeParameters() | ||
{ | ||
const string expectedParam = "42-Stateless-True-420.69-Y"; | ||
const string expectedParam = "42-Stateless-True-123.45-Y"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior of ToString is based on the current user's locale setting.
This test will fail on machines with a different locale.
One could either use ToString in the input as well or pin the locale.
Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture;
string expectedParam = $"42-Stateless-True-{123.45}-Y";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, @Fieslix, thank you. Should be resolved now.
…s with FireAsync; retrofit dotnet-state-machine#544 onto FireAsync.
…yncActionsFixture_unit_test_and_a_potential_null_reference_exception_in_InvocationInfo_class Fix NullReferenceException in the InvocationInfo class. Fix a FireAsync_TriggerWithMoreThanThreeParameters test failure because of a different system locale.
…s with FireAsync; retrofit dotnet-state-machine#544 onto FireAsync.
…ift/stateless into 565-reentry-from-dynamic-transitions
To address issue #565, this PR restores the pre-v5.15 behavior so that state re-entry is possible when dynamic transitions are used.
Example: