fix(uve): Change reload store to render the correct template/page data #30672
+42
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinDavilaDotCMS
requested review from
fmontes,
oidacra,
nicobytes and
hmoreras
|
KevinDavilaDotCMS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showcase
Screen.Recording.2024-11-15.at.11.24.42.AM.mov
This pull request includes several changes to enhance the
EditEmaLayoutComponentand related store features, mainly focusing on the addition of theisClientReadystate property and fixing a typo in theDotCMSPagesComponent.Enhancements to
EditEmaLayoutComponentand Store Features:Addition of
isClientReadyState Property:core-web/libs/portlets/edit-ema/portlet/src/lib/store/dot-uve.store.ts: AddedisClientReadyto the initial state ofUVEState.core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/client/withClient.spec.ts: AddedisClientReadyto the initial state ofUVEStatein the client feature.core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.spec.ts: AddedisClientReadyto the initial state ofUVEStatein the editor feature.core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/flags/withFlags.spec.ts: AddedisClientReadyto the initial state ofUVEStatein the flags feature.core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/layout/wihtLayout.spec.ts: AddedisClientReadyto the initial state ofUVEStatein the layout feature.core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/load/withLoad.spec.ts: AddedisClientReadyto the initial state ofUVEStatein the load feature.core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/load/withLoad.ts: Updated thereloadmethod to acceptisClientReadyand set its value accordingly. [1] [2]core-web/libs/portlets/edit-ema/portlet/src/lib/store/models.ts: AddedisClientReadyto theUVEStateinterface.Component and Store Behavior Adjustments:
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-layout/edit-ema-layout.component.ts: Modified thesaveTemplatemethod to reload the store withisClientReady: false.core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-layout/edit-ema-layout.component.spec.ts: Added a test to check thatisClientReadyis set to false after saving.Fixes and Improvements:
Typo Fix in
DotCMSPagesComponent:examples/angular/src/app/pages/pages.component.html: Corrected the typo in theeditorConfigbinding.examples/angular/src/app/pages/pages.component.ts: Fixed the typo in theeditorConfigproperty and its usage. [1] [2]Template Update in
dotcms-layout.component.ts:core-web/libs/sdk/angular/src/lib/layout/dotcms-layout/dotcms-layout.component.ts: Simplified the template by using the correct variable for page layout rows.