chore(uve): Add sort navigation to traditional and nextjs example #30624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinDavilaDotCMS
requested review from
zJaaal,
fmontes,
rjvelazco,
oidacra,
nicobytes and
hmoreras
rjvelazco
reviewed
Nov 12, 2024
zJaaal
requested changes
Nov 12, 2024
rjvelazco
reviewed
Nov 12, 2024
KevinDavilaDotCMS
changed the title
zJaaal
reviewed
Nov 12, 2024
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts
Outdated
Show resolved
Hide resolved
zJaaal
reviewed
Nov 13, 2024
fmontes
requested changes
Nov 13, 2024
fmontes
requested changes
Nov 13, 2024
…mages (without loader)
fmontes
requested changes
Nov 13, 2024
fmontes
requested changes
Nov 13, 2024
fmontes
approved these changes
Nov 13, 2024
zJaaal
reviewed
Nov 13, 2024
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts
Outdated
Show resolved
Hide resolved
zJaaal
approved these changes
Nov 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showcase:
Screen.Recording.2024-11-11.at.3.16.59.PM.mov
This pull request introduces significant changes to the
EditEmaEditorComponentand related utilities to improve the handling of menu reordering. The most important changes include the addition of a new utility function for creating reorder menu URLs, updates to theEditEmaEditorComponentto use this new function, and modifications to the SDK to support the new reorder functionality.Enhancements to menu reordering functionality:
core-web/libs/portlets/edit-ema/portlet/src/lib/utils/index.ts: Added thecreateReorderMenuURLfunction to construct URLs for the reorder menu page with specified parameters.core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts: Updated theCLIENT_ACTIONS.REORDER_MENUaction to use the newcreateReorderMenuURLfunction for generating the reorder URL.SDK updates:
core-web/libs/sdk/client/src/lib/editor/sdk-editor.ts: Added thereorderMenufunction to the SDK to handle menu reordering by sending the appropriate message to the editor.core-web/libs/sdk/client/src/index.ts: Exported the newreorderMenufunction from the SDK.Component and test updates:
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts: Added a temporary solution to reload the content by reloading the window.core-web/libs/portlets/edit-ema/portlet/src/lib/utils/utils.spec.ts: Added tests for thecreateReorderMenuURLfunction to ensure it correctly adds missing query parameters.Velocity template updates:
dotCMS/src/main/webapp/WEB-INF/velocity/VM_global_library.vm: Replaced the inline JavaScript for opening the reorder dialog with calls to the newreorderMenufunction. [1] [2]This PR fixes: #30445