Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 30619 jemalloc #30621

Merged
merged 3 commits into from
Nov 12, 2024
Merged

issue 30619 jemalloc #30621

merged 3 commits into from
Nov 12, 2024

Conversation

wezell
Copy link
Contributor

@wezell wezell commented Nov 11, 2024

  • feat(perf) adding jemalloc to our java-base image. It is not set by default but is just available.

This PR fixes: #30619

@wezell
Copy link
Contributor Author

wezell commented Nov 11, 2024

Pushed a changed dotcms/java-base:21.0.4-ms that now included jemalloc. It can be activated in subsequent docker builds with adding the env var

LD_PRELOAD=/usr/lib/aarch64-linux-gnu/libjemalloc.so.2

Copy link
Contributor

@yolabingo yolabingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wezell wezell linked an issue Nov 11, 2024 that may be closed by this pull request
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mbiuki
Copy link
Contributor

mbiuki commented Nov 12, 2024

side-note
https://semgrep.dev/orgs/dotcms1/findings/105324071

Replace apt with apt-get in the Dockerfile to ensure stability and compatibility for unattended installations.
Update the RUN command to use apt-get for all package management operations. For example, change RUN apt update && \ to RUN apt-get update && .
Ensure that all subsequent apt commands in the Dockerfile are also replaced with apt-get. For example, change apt upgrade -y && \ to apt-get upgrade -y && \ and apt install -y --no-install-recommends \ to apt-get install -y --no-install-recommends .
Verify that the Dockerfile builds successfully with the updated commands.

@wezell wezell added this pull request to the merge queue Nov 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 12, 2024
- **feat(perf) adding jemalloc to our java-base image. It is not set by
default but is just available.**
Merged via the queue into main with commit 84f04b4 Nov 12, 2024
36 checks passed
@wezell wezell deleted the issue-30619-jemalloc branch November 12, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run dotCMS with jemalloc
4 participants