fix(announcements): directive update handling of nonexistent feature flags #27709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelrojas
requested review from
zJaaal,
fmontes,
oidacra,
rjvelazco,
hmoreras and
KevinDavilaDotCMS
rjvelazco
requested changes
Feb 26, 2024
core-web/libs/data-access/src/lib/dot-properties/dot-properties.service.ts
Outdated
Show resolved
Hide resolved
...dotcms-ui/src/app/shared/directives/dot-show-hide-feature/dot-show-hide-feature.directive.ts
Outdated
Show resolved
Hide resolved
zJaaal
requested changes
Feb 26, 2024
core-web/libs/data-access/src/lib/dot-properties/dot-properties.service.ts
Outdated
Show resolved
Hide resolved
|
P.S.: This is what I understand from the issue. |
Maybe we can find another name to it. My concern is that |
oidacra
approved these changes
Feb 26, 2024
fmontes
requested changes
Feb 26, 2024
...dotcms-ui/src/app/shared/directives/dot-show-hide-feature/dot-show-hide-feature.directive.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Feb 26, 2024
core-web/libs/data-access/src/lib/dot-properties/dot-properties.service.spec.ts
Show resolved
Hide resolved
hmoreras
approved these changes
Feb 26, 2024
rjvelazco
approved these changes
Feb 26, 2024
fmontes
approved these changes
Feb 26, 2024
zJaaal
requested changes
Feb 27, 2024
core-web/libs/data-access/src/lib/dot-properties/dot-properties.service.ts
Show resolved
Hide resolved
…tent-feature-flags
zJaaal
approved these changes
Feb 27, 2024
nollymar
approved these changes
Feb 27, 2024
|
nollymar
deleted the
27708-directive-update-handling-of-nonexistent-feature-flags
branch
spbolton
pushed a commit
to spbolton/core
that referenced
this pull request
Feb 28, 2024
…flags (dotCMS#27709) * dotCMS#27708 Updating directive * dotCMS#27708 Updating directive * dotCMS#27708 PR feedback * dotCMS#27708 PR feedback * dotCMS#27708 PR feedback * dotCMS#27708 PR feedback * Adding feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request updates the feature flag directive to accommodate scenarios where the flag is not explicitly specified. In such cases, the directive now defaults to displaying the content.
Checklist
Additional Info
** any additional useful context or info **
Screenshots