Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk-experiments) fetch data from server and store in indexdb #27603 #27704

Merged
merged 18 commits into from
Mar 1, 2024
Merged

feat(sdk-experiments) fetch data from server and store in indexdb #27603 #27704

merged 18 commits into from
Mar 1, 2024

Conversation

oidacra
Copy link
Member

@oidacra oidacra commented Feb 23, 2024 •
edited
Loading

Proposed Changes

  • Fetch data from /api/v1/experiments/isUserIncluded
  • Persist raw data in the browser's IndexDB

Other changes/fixes

  • Moved .prettierignore to core-web
  • fix the double add of root .eslintrc (base and the default, nx now use .eslintrc.base.json)
  • added skip:lint and skip:test to the project with missing migration of test/lint (now can use nx run-many -t lint --exclude='tag:skip:lint' or nx run-many -t lint --exclude='tag:skip:test' to check the full dotcms project. Can replace run-many with affect to only check the affected files)
  • Change the husky to use the project tags (tag:skip:lint)

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Script loaded as IIFE

Screenshot 2024-02-27 at 5 11 47 PM

Debug mode True

Screenshot 2024-02-27 at 5 14 50 PM

@oidacra oidacra changed the title Issue 27603 sdk experiment fetch store data 2 feat(sdk-experiments) fetch data from server and store in indexdb Feb 23, 2024
@oidacra oidacra linked an issue Feb 23, 2024 that may be closed by this pull request
Implement Data Fetching and Persistence in IndexDB for @dotcms/experiments Library #27603
Closed
@oidacra oidacra force-pushed the issue-27603-sdk-experiment-fetch-store-data-2 branch 6 times, most recently from fa140e6 to 0bf9d2a Compare February 23, 2024 05:02
@oidacra oidacra force-pushed the issue-27603-sdk-experiment-fetch-store-data-2 branch from c1e6569 to 0d4ddf9 Compare February 23, 2024 15:19
fmontes
fmontes previously requested changes Feb 23, 2024
View reviewed changes
.github/workflows/frontend.yml Outdated Show resolved Hide resolved
.github/workflows/frontend.yml Outdated Show resolved Hide resolved
core-web/.husky/pre-commit Outdated Show resolved Hide resolved
core-web/.nxignore Show resolved Hide resolved
core-web/.prettierignore Outdated Show resolved Hide resolved
core-web/package.json Outdated Show resolved Hide resolved
core-web/package.json Outdated Show resolved Hide resolved
core-web/package.json Outdated Show resolved Hide resolved
core-web/package.json Outdated Show resolved Hide resolved
core-web/project.json Outdated Show resolved Hide resolved
@oidacra oidacra force-pushed the issue-27603-sdk-experiment-fetch-store-data-2 branch from c97b445 to e64261b Compare February 27, 2024 01:35
@oidacra oidacra dismissed stale reviews from fmontes and zJaaal February 27, 2024 01:37

comment fixed.

@oidacra oidacra marked this pull request as ready for review February 27, 2024 22:03
fmontes
fmontes requested changes Feb 28, 2024
View reviewed changes
.github/workflows/frontend.yml Outdated Show resolved Hide resolved
core-web/libs/sdk/experiments/src/lib/utils/utils.ts Outdated Show resolved Hide resolved
core-web/.nxignore Show resolved Hide resolved
core-web/libs/sdk/experiments/package.json Show resolved Hide resolved
core-web/libs/sdk/experiments/project.json Show resolved Hide resolved
core-web/libs/sdk/experiments/src/lib/models.ts Outdated Show resolved Hide resolved
@oidacra oidacra changed the title feat(sdk-experiments) fetch data from server and store in indexdb feat(sdk-experiments) fetch data from server and store in indexdb #27603 Feb 28, 2024
@oidacra oidacra force-pushed the issue-27603-sdk-experiment-fetch-store-data-2 branch from 1df9506 to 5c248c8 Compare February 28, 2024 17:50
zJaaal
zJaaal previously requested changes Feb 29, 2024
View reviewed changes
core-web/libs/sdk/experiments/src/lib/dot-experiments.ts Outdated Show resolved Hide resolved
core-web/libs/sdk/experiments/src/lib/dot-experiments.ts Outdated Show resolved Hide resolved
core-web/libs/sdk/experiments/src/lib/dot-experiments.ts Outdated Show resolved Hide resolved
core-web/libs/sdk/experiments/src/lib/dot-experiments.ts Outdated Show resolved Hide resolved
core-web/libs/sdk/experiments/src/lib/dot-experiments.ts Outdated Show resolved Hide resolved
core-web/libs/sdk/experiments/src/lib/dot-experiments.ts Outdated Show resolved Hide resolved
core-web/libs/sdk/experiments/src/lib/dot-experiments.ts Show resolved Hide resolved
core-web/libs/sdk/experiments/src/lib/dot-experiments.ts Outdated Show resolved Hide resolved
core-web/libs/sdk/experiments/src/lib/persistence/index-db-database-handler.ts Show resolved Hide resolved
@oidacra
fix(chore): nx changes after generate library
9166b4c
@oidacra
fix(chore): ajust husky to use tags, add dependency
4af1fc2
@oidacra
fix(chore): add tag to sdk-client library
79a7169
@oidacra
fix(chore): test trigger ci by tag
0b4c6e1
@oidacra
feat(sdk-experiments) fetch data from server and store in indexdb
ba95c73
@oidacra
fix(ci): remove not innecesary env
e815bdf
@oidacra
fix(chore): fix task in pom.xml file
f34569c
@oidacra
feat(sdk-experiments) add unit test
cc4691a
@oidacra
feat(sdk-experiments) fix comments
344335f
@oidacra
feat(sdk-experiments) change ts builder from vite to rolout.
3069964
@oidacra
feat(sdk-experiments) missing test, more doc
8ce1e7e
@oidacra
feat(sdk-experiments) fix comments
6576243
@oidacra
feat(sdk-experiments) fix mock
a972ebc
@oidacra
fix(ci): ajust node versions in maven
a17e156
@oidacra
feat(sdk-experiments) persistence from arrow functions to class, fix …
3088ed7 
…comments
@oidacra
feat(sdk-experiments) fix test error
8d7aef8
@oidacra oidacra force-pushed the issue-27603-sdk-experiment-fetch-store-data-2 branch from ccf8ee4 to 8d7aef8 Compare February 29, 2024 22:36
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
6 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@dsilvam dsilvam added this pull request to the merge queue Mar 1, 2024
Merged via the queue into master with commit c088f59 Mar 1, 2024
40 checks passed
@dsilvam dsilvam deleted the issue-27603-sdk-experiment-fetch-store-data-2 branch March 1, 2024 03:58
@oidacra oidacra restored the issue-27603-sdk-experiment-fetch-store-data-2 branch June 10, 2024 18:26
@oidacra oidacra deleted the issue-27603-sdk-experiment-fetch-store-data-2 branch June 10, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinDavilaDotCMS KevinDavilaDotCMS KevinDavilaDotCMS left review comments

@zJaaal zJaaal zJaaal left review comments

@hmoreras hmoreras hmoreras left review comments

@manuelrojas manuelrojas manuelrojas left review comments

@rjvelazco rjvelazco rjvelazco approved these changes

@fmontes fmontes fmontes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Data Fetching and Persistence in IndexDB for @dotcms/experiments Library
8 participants
@oidacra @fmontes @manuelrojas @hmoreras @zJaaal @rjvelazco @KevinDavilaDotCMS @dsilvam