Enable incremental rendering as the default in done-ssr #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to steal 2.0
Support HTTP/2
Uses new done-mutation for incremental rendering
This adds support for incremental rendering through HTTP/1. This works by attaching a `<link rel=preload>` to the document which will preload the rendering instructions, which happens in place of the H2 PUSH. Closes #582
Allow incremental rendering to occur over HTTP/1
set of TextNodes. This is a new API provided by done-mutatation. Doing this will ensure that we keep track of when text nodes were part of the original parsed document and which are added layer. This makes it so that we send the correct indices to the client layer.
In done-mutation 2.0 the collapseTextNodes option is no longer necessary. So this removes it and uses ir-clone instead for serialization.
For incremental rendering we need to split up TextNodes so that they are in the IR document. This way when we start doing mutations we can correctly identify which Nodes need to be updated.
Use ir-clone to serialize incremental rendering document
We should be serializing the iframe document using ir-clone in order to ensure that its comment nodes are injected.
Serialize iframe document
When we start out own MutationObserver stop listening to mutations using nodeIndex. This prevents us from getting indices that are updated too soon.
Use nodeIndex.reindex() to reindex after creating the IR frame
This switches the toggle so that incremental rendering is the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #481