Remove promisify, use fs/promises and glob-promise instead #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V01dgazer
commented
Mar 17, 2022
| @@ -1,9 +1,8 @@ | |||
| var Promise = require('./Promise'); | |||
| var path = require('path'); | |||
| var yaml = require('js-yaml'); | |||
| var objectAssign = require('object-assign'); | |||
There was a problem hiding this comment.
objectAssign was not being used.
|
Having memory leaks on my project. If it helps I'd really appreciate this PR being merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promisifying glob and fs modules causes memory leaks in jest tests. The intention is to get rid of promisify and use native promises instead.