Update SSLFDProxy to implement SSLSocketListener #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously SSLFDProxy.c was accessing the fields in SSLFDProxy class directly using JNI to update handshakeComplete and add SSL alert events into inboundAlerts and outboundAlerts. To make it easier to investigate SSL alert issues, SSLFDProxy has been updated to implement SSLSocketListener then SSLFDProxy.c will call SSLSocketListener methods to perform the above operations.
|
|
@fmarco76 Thanks! |
|
You may also want to remove |
|
@siteshwar Thanks for the notification. I have opened a PR to remove the method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
SSLFDProxy.cwas accessing the fields inSSLFDProxyclass directly using JNI to updatehandshakeCompleteand add SSL alert events intoinboundAlertsandoutboundAlerts.To make it easier to investigate SSL alert issues,
SSLFDProxyhas been updated to implementSSLSocketListenerthenSSLFDProxy.cwill callSSLSocketListenermethods to perform the above operations.