Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi-Samba User Mode #14

Merged
merged 12 commits into from
Oct 9, 2024
Merged

Add Multi-Samba User Mode #14

merged 12 commits into from
Oct 9, 2024

Conversation

HanLiQL
Copy link
Contributor

@HanLiQL HanLiQL commented Oct 9, 2024

When using samba, you may need to use different samba accounts to share different content.
If you run many docker container instances, it will make management more complicated.
I think it is not appropriate to start multiple container instances just because there are multiple accounts for a service.
So I modified the entrypoint script to introduce a multi-account mode.
Users can initialize multiple samba accounts and groups simultaneously by mounting configuration files, allowing for better customization of samba sharing policies.
This patch is compatible with previous versions, and existing configuration files do not need to be modified for existing users.

@xfl12345
Copy link

xfl12345 commented Oct 9, 2024

#12

@kroese kroese merged commit 83b5e3f into dockur:master Oct 9, 2024
1 check passed
@kroese
Copy link
Contributor

kroese commented Oct 9, 2024

This pull completely broke the single-user mode, because the pdbedit and smbpasswd dont expect the config file to be /etc/samba/smb.tmp.

Next time when adding new functionality, please be careful not to break the default mode because I merged it assuming you tested it.

@HanLiQL
Copy link
Contributor Author

HanLiQL commented Oct 10, 2024

Thank you for pointing out my mistake and for fixing the code. I apologize for not testing all the possible scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants