-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multi-Samba User Mode #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d passwords to make them Samba users.
This was referenced Oct 9, 2024
This pull completely broke the single-user mode, because the Next time when adding new functionality, please be careful not to break the default mode because I merged it assuming you tested it. |
Thank you for pointing out my mistake and for fixing the code. I apologize for not testing all the possible scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using samba, you may need to use different samba accounts to share different content.
If you run many docker container instances, it will make management more complicated.
I think it is not appropriate to start multiple container instances just because there are multiple accounts for a service.
So I modified the entrypoint script to introduce a multi-account mode.
Users can initialize multiple samba accounts and groups simultaneously by mounting configuration files, allowing for better customization of samba sharing policies.
This patch is compatible with previous versions, and existing configuration files do not need to be modified for existing users.