-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[27.x backport] Improve Cobra completions for run and create #5618
Merged
thaJeztah
merged 15 commits into
docker:27.x
from
thaJeztah:27.x_backport_container_completions
Nov 14, 2024
Merged
[27.x backport] Improve Cobra completions for run and create #5618
thaJeztah
merged 15 commits into
docker:27.x
from
thaJeztah:27.x_backport_container_completions
Nov 14, 2024
+378
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit 761d767) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit b598ec8) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit c555327) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit e513454) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit ac7bde6) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit 2d89339) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit 5d709a8) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit 3292afe) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit 5f7c43e) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit 9a9ae23) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit 3a2503f) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit 2915749) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit db0ed1e) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit 4525fe3) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Credits to thaJeztah Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit 06260e6) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
27.x_backport_container_completions
branch
from
November 14, 2024 16:05
a667270
to
955e003
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 27.x #5618 +/- ##
==========================================
- Coverage 58.41% 58.29% -0.13%
==========================================
Files 337 337
Lines 28899 29057 +158
==========================================
+ Hits 16881 16938 +57
- Misses 11050 11145 +95
- Partials 968 974 +6 |
robmry
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run
andcreate
#5580- What I did
Added Cobra completion for all options of
docker run
anddocker create
.- How I did it
Provided
FlagCompletionFunc
s for all options except forThe reference for my work was the legacy bash completion.
Features that I did not recreate:
--user
- How to verify it
make completion
, then try completions of variousdocker run
anddocker create
commands.. ./contrib/completion/bash/docker
. then execute the same completions for reference.- Description for the changelog
Improved completions for
docker run
anddocker create
.