Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[27.x backport] bump golangci-lint to v1.61.0 and cleanup config #5613

Merged
merged 5 commits into from
Nov 14, 2024

Commits on Nov 13, 2024

  1. golangci-lint: enable G204, add #nosec comments instead

    There's only 3 locations where it's hit, so putting #gosec ignore comments
    in those locations.
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit 020f3a7)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7a90619 View commit details
    Browse the repository at this point in the history
  2. golangci-lint: move gosec excludes to linters-settings

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit 7451339)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1890ea0 View commit details
    Browse the repository at this point in the history
  3. golangci-lint: update comment, and disable "exclude-dirs-use-default"

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit 745629b)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    35122a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. [27.x] cli: fix non-constant format string in call to errors.Errorf (…

    …govet)
    
         cli/required.go:17:24: printf: non-constant format string in call to github.com/docker/cli/vendor/github.com/pkg/errors.Errorf (govet)
         		return errors.Errorf("\n" + strings.TrimRight(cmd.UsageString(), "\n"))
         		                     ^
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    df7113d View commit details
    Browse the repository at this point in the history
  2. bump golangci-lint to v1.61.0

    Also updating a linter that was deprecated;
    
        The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit 9af049c)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8fe9372 View commit details
    Browse the repository at this point in the history