Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[27.x backport] Fix bash completion for events --filter daemon= #5563

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

vvoland
Copy link
Collaborator

@vvoland vvoland commented Oct 21, 2024

- What I did
Fixed the "legacy" bash completion for events --filter daemon= that no longer works.

- How I did it
Changed completion logic from parsing the bare docker info output to using a --filter matching the desired values.

- How to verify it
type

docker events --filter daemon=<tab><tab>

Before: no completion
With this fix: completion of ID and hostname of the current docker daemon.

- Description for the changelog
Fixed bash completion for events --filter daemon=

Fixed bash completion for `events --filter daemon=`

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Harald Albers <[email protected]>
(cherry picked from commit 3f7b156)
Signed-off-by: Paweł Gronowski <[email protected]>
@vvoland vvoland added this to the 27.4.0 milestone Oct 21, 2024
@vvoland vvoland self-assigned this Oct 21, 2024
@vvoland vvoland requested review from albers and a team as code owners October 21, 2024 09:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.65%. Comparing base (16201b3) to head (dc36908).
Report is 3 commits behind head on 27.x.

Additional details and impacted files
@@           Coverage Diff           @@
##             27.x    #5563   +/-   ##
=======================================
  Coverage   58.65%   58.65%           
=======================================
  Files         345      345           
  Lines       29042    29042           
=======================================
  Hits        17035    17035           
  Misses      11036    11036           
  Partials      971      971           

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit dd01361 into docker:27.x Oct 21, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants