Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/command: fix some minor linting issues #5557

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

thaJeztah
Copy link
Member

Leftovers from other branches 😂

cli/command/registry: fix minor linting issues

  • fix camelCase naming of verifyLoginOptions
  • suppress unhandled errors that can be ignored

cli/command: AddPlatformFlag: suppress unhandled error

- fix camelCase naming of verifyLoginOptions
- suppress unhandled errors that can be ignored

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Oct 20, 2024
@thaJeztah thaJeztah added this to the 28.0.0 milestone Oct 20, 2024
@thaJeztah thaJeztah self-assigned this Oct 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.57%. Comparing base (062eecf) to head (6b90837).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5557   +/-   ##
=======================================
  Coverage   59.57%   59.57%           
=======================================
  Files         345      345           
  Lines       29088    29088           
=======================================
  Hits        17330    17330           
  Misses      10788    10788           
  Partials      970      970           

@laurazard laurazard merged commit 7029147 into docker:master Oct 21, 2024
101 checks passed
@thaJeztah thaJeztah deleted the minor_linting_issues branch October 21, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants