-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command: change drive to lowercase for wsl path #5445
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5445 +/- ##
=======================================
Coverage 59.75% 59.75%
=======================================
Files 345 345
Lines 23428 23428
=======================================
Hits 13999 13999
Misses 8455 8455
Partials 974 974 |
Can you add (or update) a test-case in cli/cli/command/telemetry_docker_test.go Lines 11 to 29 in a4619f3
(could be a test-table if we want to add more cases to it) |
On Windows, the drive casing doesn't matter outside of WSL. For WSL, the drives are lowercase. When we're producing a WSL path, lowercase the drive letter. Co-authored-by: Jonathan A. Sternberg <[email protected]> Co-authored-by: Laura Brehm <[email protected]> Signed-off-by: Jonathan A. Sternberg <[email protected]> Signed-off-by: Laura Brehm <[email protected]>
9f0a594
to
3472bbc
Compare
@thaJeztah can you TAL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
- What I did
On Windows, the drive casing doesn't matter outside of WSL. For WSL, the drives are lowercase. When we're producing a WSL path, lowercase the drive letter.
- How I did it
Called
strings.ToLower
on the drive when creating the WSL path.- How to verify it
- Description for the changelog
* Use lowercase windows drive letter for WSL metrics path
- A picture of a cute animal (not mandatory but encouraged)