Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docstring for cli/command: ContainerFormat.CreatedAt #5415

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

lentil32
Copy link
Contributor

@lentil32 lentil32 commented Sep 8, 2024

fixes #2413

- What I did

Correct documentation for CreatedAt
As @Benehiko suggested in #4765 (comment), didn't add CreatedAtTimestamp.

- How I did it

  1. Referred to https://pkg.go.dev/time#Time.String
  2. Used commenting style as for DisplayablePorts in same file

- How to verify it

N/A, or refer to func TestContainerContextWriteJSON(t *testing.T) { in formatter/test_container.go

- Description for the changelog

cli/command: fix docstring for ContainerFormat.CreatedAt

- A picture of a cute animal (not mandatory but encouraged)

image

Copy link
Member

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (6b74160) to head (0b9d582).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5415   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files         345      345           
  Lines       23394    23394           
=======================================
  Hits        13974    13974           
  Misses       8450     8450           
  Partials      970      970           

@Benehiko Benehiko merged commit 6372ec9 into docker:master Sep 9, 2024
89 checks passed
@laurazard laurazard added this to the 27.3 milestone Sep 12, 2024
@thaJeztah thaJeztah modified the milestones: 27.3.0, 28.0.0 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContainerFormat's CreatedAt has wrong documentation
5 participants