Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update link to moved build context doc #5347

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Aug 13, 2024

- What I did

Update a link to a moved document

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.46%. Comparing base (35666cf) to head (2dd4eb0).
Report is 21 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5347   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files         299      299           
  Lines       20863    20863           
=======================================
  Hits        12823    12823           
  Misses       7125     7125           
  Partials      915      915           

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

does this need to wait for the other PR? or good to go?

@dvdksn
Copy link
Contributor Author

dvdksn commented Aug 14, 2024

I think I'll keep this open until the docs PR is merged, just in case there are any hiccups that need fixing

@thaJeztah
Copy link
Member

@dvdksn give a nudge when it's ready to be merged

@dvdksn dvdksn merged commit 0be9e2f into docker:master Aug 19, 2024
104 checks passed
@dvdksn dvdksn deleted the update-build-context-link branch August 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants