Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Require changelog description #4981

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

vvoland
Copy link
Collaborator

@vvoland vvoland commented Apr 4, 2024

ci: Require changelog description

github/ci: Check if backport is opened against the expected branch

ci/validate-pr: Use ::error:: command to print errors

@vvoland
Copy link
Collaborator Author

vvoland commented Apr 5, 2024

Converting to draft for now, will update with changes from moby.

Any PR that is labeled with any `impact/*` label should have a
description for the changelog and an `area/*` label.

(copied from moby/moby 1d473549e865ef6b90ee936c280f4bda677de39b)

Signed-off-by: Paweł Gronowski <[email protected]>
(copied from moby/moby 61269e718fbdbbad397b0089105ec910fc0e62ca)

Signed-off-by: Paweł Gronowski <[email protected]>
This will make Github render the log line as an error.

(copied from moby/moby fb92caf2aa6cf3664e11dc06ee10d114af300826)

Signed-off-by: Paweł Gronowski <[email protected]>
@vvoland vvoland marked this pull request as ready for review April 19, 2024 12:03
@vvoland vvoland modified the milestones: 27.0.0, 26.1.0 Apr 19, 2024
@codecov-commenter
Copy link

Codecov Report

Merging #4981 (c3243a8) into master (b982833) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4981      +/-   ##
==========================================
- Coverage   61.05%   61.04%   -0.01%     
==========================================
  Files         295      295              
  Lines       20647    20647              
==========================================
- Hits        12605    12603       -2     
- Misses       7146     7147       +1     
- Partials      896      897       +1     

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland merged commit 118d6ba into docker:master Apr 19, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants