otel: capture whether process was invoked from a terminal #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurazard
commented
Apr 2, 2024
laurazard
commented
Apr 2, 2024
laurazard
commented
Apr 2, 2024
Benehiko
reviewed
Apr 2, 2024
krissetto
reviewed
Apr 3, 2024
laurazard
force-pushed
the
otel-add-tty
branch
3 times, most recently
from
0cf08e0
to
eab0d85
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4978 +/- ##
==========================================
+ Coverage 60.99% 61.05% +0.05%
==========================================
Files 295 295
Lines 20621 20645 +24
==========================================
+ Hits 12578 12605 +27
+ Misses 7149 7144 -5
- Partials 894 896 +2 |
This commit adds a "terminal" attribute to `BaseMetricAttributes` that allows us to discern whether an invocation was from an interactive terminal or not. Signed-off-by: Laura Brehm <[email protected]>
krissetto
approved these changes
Apr 4, 2024
neersighted
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added a "terminal" attribute to
BaseMetricAttributesthat allows us to discern whether an invocation was from an interactive terminal or not.- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)