Dockerfile: update mvdan/gofumpt to v0.6.0 #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- full diff: mvdan/gofumpt@v0.4.0...v0.6.0 - v0.6.0 release notes: https://github.com/mvdan/gofumpt/releases/tag/v0.6.0 - v0.5.0 release notes: https://github.com/mvdan/gofumpt/releases/tag/v0.5.0 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4946 +/- ##
=======================================
Coverage 61.43% 61.44%
=======================================
Files 289 289
Lines 20241 20241
=======================================
+ Hits 12435 12437 +2
+ Misses 6904 6903 -1
+ Partials 902 901 -1 |
vvoland
approved these changes
Mar 18, 2024
vvoland
reviewed
Mar 18, 2024
| @@ -129,7 +129,6 @@ func TestGetContextFromReaderString(t *testing.T) { | |||
| tarReader := tar.NewReader(tarArchive) | |||
|
|
|||
| _, err = tarReader.Next() | |||
|
|
|||
There was a problem hiding this comment.
nit: Accidental line removal?
There was a problem hiding this comment.
No, looks like gofumpt tightened up formatting a bit for these so that there's no empty line between where the error is produced and where it's checked.
There was a problem hiding this comment.
Looks like it's this commit; mvdan/gofumpt@025a91f
previously it would already do this for the err := ... case, but now also for err = ... (pre-existing err variable) case.
vvoland
reviewed
Mar 18, 2024
| @@ -114,7 +114,6 @@ func runCreate(ctx context.Context, dockerCli command.Cli, options pluginCreateO | |||
| createCtx, err = archive.TarWithOptions(absContextDir, &archive.TarOptions{ | |||
| Compression: compression, | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
nit: Accidental line removal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- A picture of a cute animal (not mandatory but encouraged)