-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add default-network-opt daemon option #4635
Conversation
@thaJeztah I noticed this flag is not included in the man page either. Where do I update that? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4635 +/- ##
=======================================
Coverage 59.74% 59.74%
=======================================
Files 288 288
Lines 24849 24849
=======================================
Hits 14846 14846
Misses 9117 9117
Partials 886 886 |
@dvdksn dockerd man page is here; https://github.com/docker/cli/blob/5d6612798a195b30edf4244ff06f18e80b1167d5/man/dockerd.8.md#synopsis You can add the option to the "synopsis" section and the list of options under it |
Perhaps we should also have the networking section updated to (similar to the logging-driver options that can be set in |
4b633b4
to
ad65959
Compare
revised—PTAL @thaJeztah :) |
ad65959
to
485e16c
Compare
Signed-off-by: David Karlsson <[email protected]>
485e16c
to
848fe62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dvdksn if you have time to do a cherry-pick for the 24.0 branch, then this will make its way to the docs 😅 |
Signed-off-by: David Karlsson [email protected]
- What I did
Added a description for the default-network-opt flag and daemon config option
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)