Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed broken link #4613

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

achneerov
Copy link
Contributor

@achneerov achneerov commented Oct 19, 2023

  • fixes dead link in cli/CONTRIBUTING.md #937

  • What I did
    
Removed broken link in dead link in cli/CONTRIBUTING.md #937

  • How I did it
    Removed first section of CONTRIBUTING.md

  • How to verify it
    
Check CONTRIBUTING.md

  • Description for the changelog

    Removed section with broken link in contributing to Docker documentation.
    A picture of a cute animal (not mandatory but encouraged)

	Removed broken link in docker#937
- How I did it
	Removed first section of CONTRIBUTING.md
- How to verify it
	Check CONTRIBUTING.md
- Description for the changelog
	Removed broken link in contributing to Docker documentation.
A picture of a cute animal (not mandatory but encouraged)
Closes docker#937

Signed-off-by: achneerov <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (8743ffd) to head (a252a10).
Report is 1072 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4613   +/-   ##
=======================================
  Coverage   59.72%   59.72%           
=======================================
  Files         288      288           
  Lines       24846    24846           
=======================================
  Hits        14839    14839           
  Misses       9120     9120           
  Partials      887      887           

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit cdba442 into docker:master Oct 23, 2023
74 checks passed
@achneerov achneerov deleted the feature/937-remove-dead-link branch October 23, 2023 18:09
@achneerov achneerov restored the feature/937-remove-dead-link branch October 23, 2023 18:11
@achneerov achneerov deleted the feature/937-remove-dead-link branch October 23, 2023 18:11
@thaJeztah thaJeztah added this to the 25.0.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dead link in cli/CONTRIBUTING.md
4 participants