replace dockerfile/dockerignore with patternmatcher/ignorefile #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
changed the title
thaJeztah
force-pushed
the
patternmatcher_dockerignore
branch
2 times, most recently
from
cd98295
to
c085b31
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4514 +/- ##
==========================================
- Coverage 59.35% 59.34% -0.01%
==========================================
Files 288 288
Lines 24783 24787 +4
==========================================
Hits 14711 14711
- Misses 9191 9195 +4
Partials 881 881 |
thaJeztah
force-pushed
the
patternmatcher_dockerignore
branch
from
c085b31
to
47f2a8a
Compare
- integrate frontend/dockerfile/dockerignore from buildkit full diff: moby/patternmatcher@v0.5.0...v0.6.0 Signed-off-by: Sebastiaan van Stijn <[email protected]>
The BuildKit dockerignore package was migrated to the patternmatcher repository / module. This patch updates our uses of the BuildKit package with its new location. A small local change was made to keep the format of the existing error message, because the "ignorefile" package is slightly more agnostic in that respect and doesn't include ".dockerignore" in the error message. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
patternmatcher_dockerignore
branch
from
47f2a8a
to
5bff123
Compare
rumpl
approved these changes
Aug 23, 2023
vvoland
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vendor: github.com/moby/patternmatcher v0.6.0
full diff: moby/patternmatcher@v0.5.0...v0.6.0
replace dockerfile/dockerignore for patternmatcher/ignorefile
The BuildKit dockerignore package was migrated to the patternmatcher
repository / module. This patch updates our uses of the BuildKit package
with its new location.
A small local change was made to keep the format of the existing error message,
because the "ignorefile" package is slightly more agnostic in that respect
and doesn't include ".dockerignore" in the error message.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)