Bump to QEMU 4.2.0 #24
Conversation
|
Never mind looks like this is a big deal and not a one liner ! Looks like the qemu fork needs to be updated |
|
Looking at the differences between the forked and upstream qemu for say 4.0.0, 4.1.0: Looks like the only difference is: |
|
Funny, looks like golang already tolerates 33 and 64. So we don't really need the fork 64 was added first in golang/go@2aef675 |
We don't really need to use the fork as the changes are already in golang to ignore signals 33 and 64 since golang 1.11: - golang/go@2aef675 - golang/go@c0e5485 Let's just start using qemu/qemu repository directly. Signed-off-by: Davanum Srinivas <[email protected]>
|
Nice find! Looks like we should be able to archive https://github.com/moby/qemu then? |
|
Ooops. Guess I could've looked under Golang when I was working on this. 😬
…On Sun, May 3, 2020 at 6:54 PM Sebastiaan van Stijn < ***@***.***> wrote:
Nice find! Looks like we should be able to archive
https://github.com/moby/qemu then?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#24 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQH4IQX4PUZJTV5OUVGJCLRPXY3PANCNFSM4MXLJW2A>
.
|
|
Bonus : since those 2 golang patches are in golang 1.11 already and currently even 1.11 is gone out of support, we should totally moth ball the |
|
Oh; I see there's one open PR against the fork; moby/qemu#7 - @tuonga do you know if that's still needed, and if so, should that be upstreamed directly? |
|
Tibor can better comment on the outstanding PR but the main purpose was to
get Docker in Docker working under QEMU. Most if not all changes in there
are probably worth upstreaming.
…On Mon., May 4, 2020, 7:18 a.m. Sebastiaan van Stijn, < ***@***.***> wrote:
Oh; I see there's one open PR against the fork; moby/qemu#7
<moby/qemu#7> - @tuonga
<https://github.com/tuonga> do you know if that's still needed, and if
so, should that be upstreamed directly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQH4IU3M7ZNRGJABGR6IIDRP2P7BANCNFSM4MXLJW2A>
.
|
This has fixed a lot of outstanding emulation issues, see comments in docker/binfmt#24 Signed-off-by: Justin Cormack <[email protected]>
|
Also had a chat with @justincormack about archiving the moby/qemu repo; he mentioned it would probably be ok for this repository to use the upstream, but that the moby/qemu repo would still be useful as a place to work on patches (to be upstreamed later) |
|
@justincormack @thaJeztah Done! i've updated this PR to point to qemu/qemu and 4.2.0. Let's ship it! :) |
|
I don't think there is any point using this repo at all if it doesn't carry patches, I opened linuxkit/linuxkit#3515 to just update LinuxKit to use 4.2.0, this was the original source of the binfmt package. |
|
@justincormack so we can close out this repo as well? Nice! |
|
Closing in favour of upstream LinuxKit |
Fixes #23
Signed-off-by: Davanum Srinivas [email protected]