-
Notifications
You must be signed in to change notification settings - Fork 334
Commit
(since it's effectively EOL now except the possibility of a severe regression: https://www.ruby-lang.org/en/news/2024/04/23/ruby-3-0-7-released/)
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,13 +50,13 @@ RUN set -eux; \ | |
} >> /usr/local/etc/gemrc | ||
|
||
ENV LANG C.UTF-8 | ||
{{ if .version | . == "3.0.6" or . == "3.1.4" or . == "3.2.2" then ( -}} | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
tianon
Author
Member
|
||
|
||
# https://www.ruby-lang.org/{{ .post | ltrimstr("/") }} | ||
{{ if env.version == "3.0" then ( -}} | ||
ENV RUBY_MAJOR {{ env.version }} | ||
ENV RUBY_VERSION {{ .version }} | ||
ENV RUBY_DOWNLOAD_SHA256 {{ .sha256.xz }} | ||
{{ ) else ( -}} | ||
|
||
# https://www.ruby-lang.org/{{ .post | ltrimstr("/") }} | ||
ENV RUBY_VERSION {{ .version }} | ||
ENV RUBY_DOWNLOAD_URL {{ .url.xz }} | ||
ENV RUBY_DOWNLOAD_SHA256 {{ .sha256.xz }} | ||
|
@@ -203,7 +203,7 @@ RUN set -eux; \ | |
fi; \ | ||
{{ ) else "" end -}} | ||
\ | ||
{{ if .version | . == "3.0.6" or . == "3.1.4" or . == "3.2.2" then ( -}} | ||
{{ if env.version == "3.0" then ( -}} | ||
{{ if .url.xz != "https://cache.ruby-lang.org/pub/ruby/\(env.version | rtrimstr("-rc"))/ruby-\(.version).tar.xz" then error("url for \(.version) is not as expected!") else "" end -}} | ||
wget -O ruby.tar.xz "https://cache.ruby-lang.org/pub/ruby/${RUBY_MAJOR%-rc}/ruby-$RUBY_VERSION.tar.xz"; \ | ||
{{ ) else ( -}} | ||
|
@tianon This made our
RUBY_MAJOR
env var we're relying on in our Dockerfile vanish. We're using this env var for setting theBUNDLE_BIN_PATH
(e.g.vendor/bundle/ruby/3.1.0/...
). So we were using ruby 3.1.4 and now with 3.1.5, the BUNDLE_BIN_PATH becamevendor/bundle/ruby/.0
. Sure, I can workaround this, but the change seems wrong and it might affect others!