-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch should_sign to an output and add signing data #40
Switch should_sign to an output and add signing data #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
94baf26
to
e3dcacb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
9805817
to
232c17c
Compare
@tianon this is ready to go |
232c17c
to
f7d54e6
Compare
f7d54e6
to
b7e59af
Compare
Is there a way to add more to this so that it is all the So, I think this PR should also have the Sign steps in their own job (one job with multiple steps or multiple jobs 🤷) so that we can have a complete change that exercises the |
6493476
to
fe95afc
Compare
All the changes are in place and shown to be working in the test repo, right? The idea was to provide multiple smaller PRs so things are easier to review. If you want to see them all together you can look in the testing repo. |
fe95afc
to
8c02ed0
Compare
This serves multiple purpose. Using output instead of environment allows using the data in subsequence jobs as well as steps making it more flexible. The PR also gets the data necessary for signing from the
builds.json
so the file isn't needed in subsequent jobs.