-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azul Zulu images #2320
base: master
Are you sure you want to change the base?
Add Azul Zulu images #2320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest docker-library PR, docker-library/official-images#16141, appears to be adding azul-zulu
, so the path of these files should be updated from zulu/
to azul-zulu/
.
azul-zulu/content.md
Outdated
* Azul Zulu 17 based on Ubuntu: | ||
``` | ||
docker run -it --rm azul/azul-zulu:17 java -version | ||
``` | ||
* Azul Zulu 17 based on Debian: | ||
``` | ||
docker run -it --rm azul/azul-zulu-debian:17 java -version | ||
``` | ||
* Azul Zulu 17 based on CentOS: | ||
``` | ||
docker run -it --rm azul/azul-zulu-centos:17 java -version | ||
``` | ||
* Azul Zulu 17 based on Alpine: | ||
``` | ||
docker run -it --rm azul/azul-zulu-alpine:17 java -version | ||
``` | ||
* Azul Zulu 17 based on Distroless: | ||
``` | ||
docker run -it --rm azul/azul-zulu-distroless:17 --version | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commands still all reference non-existent images. The PR to create a new DOI, docker-library/official-images#14593 , would create the images in the repository azul-zulu-openjdk
, so the images would look something like azul-zulu-openjdk:17-ubuntu
, i.e., there is no namespace and the base image type appears in the tag, not the repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct @whalelines, I modified this pull request to align with DOI merge request docker-library/official-images#16141.
But this means both pull requests should get approved and published together?
FYI as mentioned in the last comment in docker-library/official-images#14593, the correct merge request for DOI Azul Zulu is docker-library/official-images#16141
great, thank you, and can you also merge it, @LaurentGoderre? |
Your continued patience is appreciated. |
Proposal to add the Azul Zulu images as official images.
Relates to docker-library/official-images#14593Relates to docker-library/official-images#16141