Many changes (fix bugs, support Labeled Places) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnicodeDecodeError: 'charmap' codec can't decode byte ... character maps to <undefined>
UnsupportedOperation: detach Shouldn't be necessary in modern interpreters?
So it doesn't display at all
An address of the form `Avenue U &, E 33rd St` was causing ExpatError: not well-formed (invalid token) Because XML requires it to be encoded as &
Each new file was continuing the sequence from the last one (The Document ID is not affected, though. Still need to completely restart interpreter to make that repeatable from one KML to the next?)
Saved Places format:
```json
{'geometry': {'coordinates': [...], 'type': 'Point'},
'properties': {'Google Maps URL': '...',
'Location': {'Address': '...',
'Business Name': '...',
'Country Code': 'US',
'Geo Coordinates': {'Latitude': '...', 'Longitude': '...'}},
'Published': '2018-05-02T01:46:02Z',
'Title': '...',
'Updated': '2018-05-02T01:46:02Z'},
'type': 'Feature'}
```
Labeled Places format:
```json
{'geometry': {'coordinates': [...], 'type': 'Point'},
'properties': {'address': '...',
'name': 'Home'},
'type': 'Feature'}
```
So you can it from the command line
endolith
changed the title
Actually neither is true of original .json file. This must be a Python simplekml issue? Names are already encoded but addresses are not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated this to get it working with all of my Takeout files, both
Saved PlacesandLabeled Places. You can pull whichever changes you want.