Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gobject and wrap it into C++ object #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

edcuba
Copy link

@edcuba edcuba commented Oct 30, 2017

@dmach
Copy link
Owner

dmach commented Oct 30, 2017

Could you move swdbpackage into a different place?
It represents a database record rather than an actual package.

Following structure would be ideal:

  • libdnf
    • swdb.h (top-level header for swdb: #include "swdb/package.h" etc.)
    • swdb
      • package.h
      • package.c

@edcuba edcuba force-pushed the master branch 2 times, most recently from 1a6cfa1 to 8b38ff2 Compare October 31, 2017 08:04
@edcuba
Copy link
Author

edcuba commented Oct 31, 2017

I moved the gobjects, what about the C++ wrappers?
Should I keep them in package.cpp or better create a separate header/source for wrapping these objects? I guess it could be placed in swdb.hpp.

@edcuba
Copy link
Author

edcuba commented Nov 6, 2017

@dmach Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants