Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 24824 - ensure we exit a child that does not succeed in exec. #9065

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix issue 24824 - ensure we exit a child that does not succeed in exec. #9065

merged 1 commit into from
Oct 22, 2024
+6 −5

Conversation

schveiguy
Copy link
Member

This took a better part of my week to chase down...

@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 22, 2024 •
edited
Loading

Thanks for your pull request, @schveiguy!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 24824 major std.process.browse returns on failure in forked child

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#9065"

@thewilsonator thewilsonator merged commit 10076ba into dlang:stable Oct 22, 2024
10 checks passed
@schveiguy schveiguy deleted the fix24824 branch October 23, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@CyberShadow CyberShadow Awaiting requested review from CyberShadow CyberShadow is a code owner

@kyllingstad kyllingstad Awaiting requested review from kyllingstad kyllingstad is a code owner

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schveiguy @dlang-bot @thewilsonator