Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly mark lines constructor #9034

Closed
wants to merge 1 commit into from
Closed

Conversation

schveiguy
Copy link
Member

Still need

  • bug report
  • test

I just first want to see that it doesn't break anything.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @schveiguy!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9034"

@thewilsonator
Copy link
Contributor

You need to make this PR from your own fork.

@schveiguy
Copy link
Member Author

Well, that sucks. because I just used the github editor, and there's no way to use my fork that way...

@thewilsonator
Copy link
Contributor

you can if you browse your fork and make the changes there

@schveiguy schveiguy closed this Jul 29, 2024
@schveiguy schveiguy mentioned this pull request Jul 29, 2024
2 tasks
@schveiguy schveiguy deleted the schveiguy-patch-1 branch July 29, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants