Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isQualifierConvertible in isInputRange!(R, E) #8830

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

pbackus
Copy link
Contributor

@pbackus pbackus commented Oct 27, 2023

This replaces the bespoke type comparison that was previously used. All conversions allowed by the previous version are still allowed after this change.

See #8828 and related threads for discussion.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8830"

@pbackus pbackus force-pushed the isinputrange-qual-convertible branch from fcbca57 to 977e6ad Compare October 27, 2023 18:02
@Imperatorn
Copy link
Contributor

styleCheck etc std -I.
std/range/primitives.d(183:11)[warn]: Variable "isInputRange" has the same name as a variable defined on line 175.
make: *** [posix.mak:587: dscanner] Error 1
🚨 Error: The command exited with status 2

@pbackus
Copy link
Contributor Author

pbackus commented Oct 29, 2023

Apparently this is a known issue with D-Scanner: dlang-community/D-Scanner#323

Looks like a bunch of modules in Phobos already have this check disabled, probably for this exact reason. I'll add std.range.primitives to the list.

This replaces the bespoke type comparison that was previously used. All
conversions allowed by the previous version are still allowed after this
change.
@dlang-bot dlang-bot merged commit c4cbe0c into dlang:master Oct 31, 2023
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants