Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.traits: Adapt unittest to pass with -preview=in #7614

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Aug 31, 2020

Redo of #7609 after it was reverted because a library relied on a bug that has since been fixed (revert: #7611 , bugfix: #7612 ).

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7614"

@Geod24 Geod24 requested a review from wilzbach August 31, 2020 02:04
Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for Buildkite this time :)

@Geod24
Copy link
Member Author

Geod24 commented Aug 31, 2020

The commit that broke Buildkite was in #7612 . But yeah, no problem. Also, we should really fix the bug, especially since we're moving stuff away from the auto-tester... And/or make some more checks required ?

@wilzbach
Copy link
Member

Also, we should really fix the bug, especially since we're moving stuff away from the auto-tester...

It wasn't a bug here. It was merged manually. The bug only applies to GitHub actions as they aren't returned by the traditional CI APi.

And/or make some more checks required ?

Yes, that's the one. Yesterday I set more checks as required on DMD and I think we just need to do the same here. Considering our history IMHO all CIs should be set as required.

@Geod24
Copy link
Member Author

Geod24 commented Aug 31, 2020

It wasn't a bug here. It was merged manually. The bug only applies to GitHub actions as they aren't returned by the traditional CI APi.

Also Azure (dlang/dlang-bot#250).

@dlang-bot dlang-bot merged commit 35016ff into dlang:master Aug 31, 2020
@Geod24 Geod24 deleted the std-traits-in-ref branch August 31, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants