Call vdeprecationSupplemental from deprecationSupplemental

[ibuclaw]

Seems like it should do this to be consistent with errorSupplemental and warningSupplemental.

[dlang-bot]

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

[mathias-lang-sociomantic]

You have to change some tests it seems

[ibuclaw]

I thought that might be the case.

[ibuclaw]

@mathias-lang-sociomantic - you seem to have merged the commit in a weird way.

[mathias-lang-sociomantic]

How weird ? It was a Rebase & Merge

[ibuclaw]

There is no merge commit.

[ibuclaw]

Next time, try using the auto-merge label.

[PetarKirov]

@ibuclaw While in general I agree that using the auto-merge is a good practice, I don't see the problem with using "Rebase and merge" as long as it keeps a reference to the pull request, which it does by default. We were using this, in addition to "Squash and merge" successfully for dlang-tour before we deployed dlang-bot there too.

[wilzbach]

before we deployed dlang-bot there too.

FWIW the bot supports the labels "auto-merge-squash" and "auto-merge-rebase" too, they aren't available here, because unfortunately there has been a precedent in which the squashing was "abused" :/

I don't see the problem with using "Rebase and merge" as long as it keeps a reference to the pull request, which it does by default. We were using this, in addition to "Squash and merge" successfully for dlang-tour

Yup. Many projects I worked on even had this as the only allowed merging strategy.

[mathias-lang-sociomantic]

There is no merge commit.

Yep, that's the point of it actually. You should know that, because all D developpers around you are using this approach ;)

The point of not having a merge commit is to make the history more readable. A linear history is much easier to read than one polluted by merge commits. Compare ocean's history which use rebase approach:

With dmd's:

(Generated using log --color --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit)

Now if there's a technical issue or policy or strong preference from someone not to use rebase & merge I'll switch to merge approach of course, I was just surprised this could be an issue :)

[wilzbach]

Now if there's a technical issue or policy or strong preference from someone not to use rebase & merge I'll switch to merge approach of course

There such a policy (yet). In fact, e.g. we wanted to switch to squashing for a long time:

dlang/dlang-bot#64

(so AFAICT nothing is set into stones here, it's just missing time)