Mastic client implementation #1087

hannahdaviscrypto · 2024-06-28T16:00:53Z

Partially addresses #947.

Implements sharding for the Mastic VDAF, and adjusts the VIDPF and SZK modules in support of this development.

src/codec.rs

src/flp/szk.rs

src/vidpf.rs

src/mastic.rs

src/flp/szk.rs

src/mastic.rs

src/flp/szk.rs

src/vidpf.rs

src/vdaf/mastic.rs

src/codec.rs

src/flp/szk.rs

src/vidpf.rs

src/vdaf.rs

src/vidpf.rs

cjpatton

Looks good. Most of my comments are about readability or Rust conventions, just a couple of more substantive suggestions.

src/vdaf/mastic.rs

src/flp/szk.rs

src/codec.rs

src/flp/szk.rs

src/vdaf/mastic.rs

src/vidpf.rs

src/flp/szk.rs

src/vdaf.rs

src/vidpf.rs

src/vdaf/mastic.rs

src/codec.rs

src/vdaf/mastic.rs

src/flp/szk.rs

src/vidpf.rs

Implements client functionality for the Mastic protocol for weighted heavy-hitters and attribute-based metrics.

hannahdaviscrypto requested a review from a team as a code owner June 28, 2024 16:00

divergentdave reviewed Jul 1, 2024

View reviewed changes

cjpatton reviewed Jul 2, 2024

View reviewed changes

hannahdaviscrypto force-pushed the mastic-main-dev branch 2 times, most recently from eeffa81 to d82908f Compare July 16, 2024 17:25

hannahdaviscrypto requested a review from cjpatton July 18, 2024 20:11

divergentdave reviewed Jul 19, 2024

View reviewed changes

cjpatton reviewed Jul 19, 2024

View reviewed changes

hannahdaviscrypto requested review from cjpatton and divergentdave July 23, 2024 17:32

divergentdave reviewed Jul 26, 2024

View reviewed changes

src/flp/szk.rs Outdated Show resolved Hide resolved

src/vidpf.rs Outdated Show resolved Hide resolved

src/vdaf.rs Outdated Show resolved Hide resolved

src/vidpf.rs Outdated Show resolved Hide resolved

src/vidpf.rs Outdated Show resolved Hide resolved

cjpatton reviewed Jul 29, 2024

View reviewed changes

hannahdaviscrypto force-pushed the mastic-main-dev branch 6 times, most recently from e2fb102 to 032b4ae Compare August 6, 2024 16:36

cjpatton reviewed Aug 7, 2024

View reviewed changes

divergentdave reviewed Aug 7, 2024

View reviewed changes

hannahdaviscrypto requested review from cjpatton and divergentdave August 8, 2024 18:45

divergentdave approved these changes Aug 9, 2024

View reviewed changes

src/codec.rs Outdated Show resolved Hide resolved

src/vdaf/mastic.rs Outdated Show resolved Hide resolved

src/vdaf/mastic.rs Outdated Show resolved Hide resolved

cjpatton reviewed Aug 9, 2024

View reviewed changes

src/vdaf/mastic.rs Outdated Show resolved Hide resolved

src/vdaf/mastic.rs Outdated Show resolved Hide resolved

src/vdaf/mastic.rs Outdated Show resolved Hide resolved

hannahdaviscrypto force-pushed the mastic-main-dev branch 5 times, most recently from fe9bfcc to f01cdca Compare August 12, 2024 15:05

divergentdave reviewed Aug 12, 2024

View reviewed changes

src/vdaf/mastic.rs Outdated Show resolved Hide resolved

cjpatton approved these changes Aug 12, 2024

View reviewed changes

src/flp/szk.rs Show resolved Hide resolved

src/vidpf.rs Outdated Show resolved Hide resolved

Create Mastic module with client implementation

e0e1fbc

Implements client functionality for the Mastic protocol for weighted heavy-hitters and attribute-based metrics.

hannahdaviscrypto force-pushed the mastic-main-dev branch from f01cdca to e0e1fbc Compare August 13, 2024 16:18

hannahdaviscrypto closed this Aug 13, 2024

hannahdaviscrypto reopened this Aug 13, 2024

cjpatton merged commit 087b647 into divviup:main Aug 13, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mastic client implementation #1087

Mastic client implementation #1087

hannahdaviscrypto commented Jun 28, 2024 •

edited by cjpatton

Loading

cjpatton left a comment

Mastic client implementation #1087

Mastic client implementation #1087

Conversation

hannahdaviscrypto commented Jun 28, 2024 • edited by cjpatton Loading

cjpatton left a comment

Choose a reason for hiding this comment

hannahdaviscrypto commented Jun 28, 2024 •

edited by cjpatton

Loading