-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving to python3 #34
Open
Zdrul
wants to merge
18
commits into
master
Choose a base branch
from
moving-to-python3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jun 25, 2016
-
Configuration menu - View commit details
-
Copy full SHA for fc6877b - Browse repository at this point
Copy the full SHA fc6877bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49043bb - Browse repository at this point
Copy the full SHA 49043bbView commit details
Commits on Jun 26, 2016
-
Add compat module for Python3 compatibility
It provides a nice overview of the tweaks which we see in the codebase, so that it supports both Python2 and Python3.
Configuration menu - View commit details
-
Copy full SHA for b65327a - Browse repository at this point
Copy the full SHA b65327aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 190f70e - Browse repository at this point
Copy the full SHA 190f70eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f00414 - Browse repository at this point
Copy the full SHA 0f00414View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e3e3f6 - Browse repository at this point
Copy the full SHA 6e3e3f6View commit details -
Encode switch names into bytes
Background idea is that we use string types as switch names and if we do this consistently, then the keys can be encoded into bytes objects. At least the RedisDict as storage will otherwise happily take str instances and return bytes instances. Result is that the Manager cannot find the switches anymore and we see issues due to mixing up str and bytes.
Configuration menu - View commit details
-
Copy full SHA for ed92642 - Browse repository at this point
Copy the full SHA ed92642View commit details -
Rich comparison handling for Python3
__cmp__ is ignored and cmp() is gone. Only one way left to compare.
Configuration menu - View commit details
-
Copy full SHA for 4e34985 - Browse repository at this point
Copy the full SHA 4e34985View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11bdbb9 - Browse repository at this point
Copy the full SHA 11bdbb9View commit details
Commits on Apr 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8f6837a - Browse repository at this point
Copy the full SHA 8f6837aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7f2ddf - Browse repository at this point
Copy the full SHA a7f2ddfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0bd30a - Browse repository at this point
Copy the full SHA f0bd30aView commit details
Commits on Apr 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 494f36c - Browse repository at this point
Copy the full SHA 494f36cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c08283f - Browse repository at this point
Copy the full SHA c08283fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23327d8 - Browse repository at this point
Copy the full SHA 23327d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 094c8cc - Browse repository at this point
Copy the full SHA 094c8ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41d7368 - Browse repository at this point
Copy the full SHA 41d7368View commit details -
Configuration menu - View commit details
-
Copy full SHA for 385a6d0 - Browse repository at this point
Copy the full SHA 385a6d0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.