Dependency bumps 2024/09, fix version format #11
+27
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kubukoz
changed the title
kubukoz
commented
Sep 30, 2024
| ivy"software.amazon.smithy:smithy-waiters:$smithyVersion" | ||
| ivy"software.amazon.smithy:smithy-waiters:$smithyVersion", | ||
| ivy"software.amazon.smithy:smithy-aws-endpoints:$smithyVersion", | ||
| ivy"software.amazon.smithy:smithy-aws-smoke-test-model:$smithyVersion" |
There was a problem hiding this comment.
question: what are we doing about those? #9 (comment)
kubukoz
commented
Sep 30, 2024
| @@ -46,7 +46,7 @@ jobs: | |||
| mill -i __.publishArtifacts | |||
| mill -i io.kipp.mill.ci.release.ReleaseModule/publishAll | |||
| env: | |||
| PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }} | |||
| PGP_PASSPHRASE: "" | |||
There was a problem hiding this comment.
thought: the new key doesn't have a passphrase (generated in-browser on https://typelevel.org/sbt-typelevel/secrets.html)
kubukoz
commented
Sep 30, 2024
| @@ -1,8 +1,8 @@ | |||
| name: Continuous Integration | |||
|
|
|||
| on: | |||
| # pull_request: | |||
| # branches: ["*"] | |||
| pull_request: | |||
There was a problem hiding this comment.
thought: this meant PRs wouldn't have any CI whatsoever, seems to be by omission.
kubukoz
commented
Sep 30, 2024
Comment on lines
+43
to
+46
| - name: Build packages | ||
| run: | | ||
| mill -i __.jar | ||
|
|
There was a problem hiding this comment.
thought: seems to be the closest thing to package in sbt. Just compiling didn't discover the issues with missing traits because we need to run resources, at the very least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.