Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement synthesis #4

Merged
merged 14 commits into from
Oct 21, 2023
Merged

Implement synthesis #4

merged 14 commits into from
Oct 21, 2023

Conversation

femshima
Copy link
Contributor

No description provided.

Copy link
Collaborator

@cm-ayf cm-ayf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synthesisのシグニチャを守ってくれたところ恐縮ですが、アレには大した意味が無かったのです……
あと、スロットリングはここにあるようにWorkerPoolの責務ですが、現状Pioelineでもやってしまっているので、その辺を消していただけると……

build.js Outdated Show resolved Hide resolved
src/synthesis/index.ts Outdated Show resolved Hide resolved
@femshima femshima marked this pull request as ready for review October 21, 2023 23:47
@cm-ayf cm-ayf merged commit ed61c46 into discordjs-japan:main Oct 21, 2023
1 check passed
@femshima femshima deleted the synthesis branch October 22, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants