Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf9151 preview #23

Merged
merged 11 commits into from
Aug 9, 2024
Merged

nrf9151 preview #23

merged 11 commits into from
Aug 9, 2024

Conversation

nerwalt
Copy link
Contributor

@nerwalt nerwalt commented Aug 1, 2024

Adding support for the nrf9120 (nrf9151 and nrf9161)

Making nrf-modem work with the newest nrfxlib-sys (nordic nrfxlib v.2.7.0)
@nerwalt
Copy link
Contributor Author

nerwalt commented Aug 1, 2024

This is a draft/WIP PR. It depends on nrflixb-sys getting updated to v2.7.0. I submitted a PR for that earlier. Also, a few new FFI functions need to be filled in

src/lib.rs Show resolved Hide resolved
src/ffi.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@diondokter
Copy link
Owner

Can we think of a reason why this would be a breaking change? IIRC we don't forward any types from nrfxlib-sys...
But maybe just bump it to make sure and make this version 0.5?

Pinning nrfxlib-sys version

Co-authored-by: Dion Dokter <[email protected]>
@diondokter
Copy link
Owner

Alright, looks pretty decent now

@nerwalt
Copy link
Contributor Author

nerwalt commented Aug 2, 2024

I am unsure what to do about nrf_modem_os_log and nrf_modem_os_logdump. I don't need them right now and they aren't required, so leaving them as stubs seems fine. I have seen a few other crates provide logging hooks with a thin C function (to handle the variadic args). For example, https://github.com/Ragarnoy/a121-sys. A similar approach could be done here and hook it into defmt.

@diondokter
Copy link
Owner

I am unsure what to do about nrf_modem_os_log and nrf_modem_os_logdump. I don't need them right now and they aren't required, so leaving them as stubs seems fine. I have seen a few other crates provide logging hooks with a thin C function (to handle the variadic args). For example, https://github.com/Ragarnoy/a121-sys. The same could be done here and hook it into defmt.

Yeah just leave them as stubs for now. That's fine.
If someone wants to implement it, then they can send a PR.

@nerwalt nerwalt marked this pull request as ready for review August 9, 2024 11:54
@diondokter diondokter merged commit 8e5991c into diondokter:master Aug 9, 2024
1 check passed
@nerwalt nerwalt deleted the nrf9151-preview branch August 9, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants