include submission time slot in opportunity API #413
Conversation
|
This PR needs a description |
| @@ -178,6 +185,18 @@ def get_catchment_areas(self, obj): | |||
| catchments = CatchmentArea.objects.filter(opportunity_access=opp_access) | |||
| return CatchmentAreaSerializer(catchments, many=True).data | |||
|
|
|||
| @lru_cache | |||
| def _get_flags(self, obj): | |||
| return OpportunityVerificationFlags.objects.filter(opportunity=obj).first() | |||
There was a problem hiding this comment.
should this use .get instead or even obj.opportunityverificationflags? It's a OneToOne model, we can guarantee there is only one so filter and first seem unnecessary. Given that we can use normal accessor syntax, this whole cached get may be unnecessary, since it will be loaded the first time its accessed and already saved on the object the later times (rather than saved in redis)
There was a problem hiding this comment.
Good point, I totally overlooked it. I have updated the code and also addressed the rest of the comments too.
| @@ -105,6 +108,8 @@ class OpportunitySerializer(serializers.ModelSerializer): | |||
| payment_units = serializers.SerializerMethodField() | |||
| is_user_suspended = serializers.SerializerMethodField() | |||
| catchment_areas = serializers.SerializerMethodField() | |||
| start_time_threshold = serializers.SerializerMethodField() | |||
There was a problem hiding this comment.
As an extension of my comment below, I am not sure this needs a method rather than just the source argument. Alternatively, I think this might be nicer in a new verification_flags object, rather than at the top level, since we are likely to add the others and it will help with organization.
| @@ -133,6 +138,8 @@ class Meta: | |||
| "payment_units", | |||
| "is_user_suspended", | |||
| "catchment_areas", | |||
| "start_time_threshold", | |||
There was a problem hiding this comment.
Is there a specific reason to change the names here? It obviously doesn't really matter but it does add a tiny bit of inconsistency between what the mobile and web team will call these which can be annoying.
sravfeyn
force-pushed
the
sr/workhours
branch
from
2087306
to
97c2f25
Compare
No description provided.