Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding consistent ordering to visit export #412

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

calellowitz
Copy link
Collaborator

I think this should fix the flaky test (and make sure that visit exports are always in the same order, which might be nice anyway).

@hemant10yadav
Copy link
Contributor

Ordering by pk may still fail because during bulk creation, the database does not guarantee sequential pk assignment based on the order of the objects in our code. This can result in the second record being inserted first and getting a lower pk than the first record. As a result, even if we order by pk, the output may not match the expected order (e.g., by visit_date), causing test to fail.

@calellowitz
Copy link
Collaborator Author

Offlined with Hemant, and we are both convinced PK ordering should be sufficient. Previous failures were due to a different issue.

@calellowitz calellowitz merged commit c8549a7 into main Oct 9, 2024
2 checks passed
@calellowitz calellowitz deleted the ce/visit-export-order branch October 9, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants