Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Invoice List Internationalization #409

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix Invoice List Internationalization #409

merged 2 commits into from
Oct 8, 2024

Conversation

pxwxnvermx
Copy link
Contributor

Fixed translate tag not working in the invoice list template due to missing initialization for internationalization tags.

@pxwxnvermx pxwxnvermx self-assigned this Oct 8, 2024
calellowitz
calellowitz approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this in one of our base templates? Otherwise looks good

@pxwxnvermx
Copy link
Contributor Author

We do have it in the base template. I don't know why that does not also apply to the templates that inherit the base.

@pxwxnvermx pxwxnvermx merged commit e22c8ee into main Oct 8, 2024
2 checks passed
@pxwxnvermx pxwxnvermx deleted the pkv/fix-invoices-list branch October 8, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calellowitz calellowitz calellowitz approved these changes

@hemant10yadav hemant10yadav Awaiting requested review from hemant10yadav

Assignees

@pxwxnvermx pxwxnvermx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pxwxnvermx @calellowitz