Show payment metrics #405
Show payment metrics #405
Conversation
| for payment in payments: | ||
| paid += payment.amount | ||
|
|
||
| while paid > current_work.payment_accrued: |
There was a problem hiding this comment.
This is missing the logic deducts from the total paid when we assign that payment to a completed work. Right now this will run forever in most cases, because the total paid out is always greater than what is due for the next completed work. For example if each work accrues $5 and the first payment was $10, 10 is always greater than 5. We need to deduct what we are assigning to the work, or keep a similar running total for what we owe.
There was a problem hiding this comment.
Since this will be used internally only for now, going to merge this. I imagine there is a way to simplify that algorithm, which is quite difficult to follow with all the breaks and continues, but it looks correct, and this will allow people to start looking at the data
https://dimagi.atlassian.net/browse/CCCT-493