Network manager funnel performance #391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemant10yadav
changed the title
Base automatically changed from
hy/invite-program
to
hy/managed-opportunity-creation
September 18, 2024 06:54
…rk-manager-funnel-performance
calellowitz
reviewed
Oct 3, 2024
| ) | ||
| .exclude(status__in=[VisitValidationStatus.over_limit, VisitValidationStatus.trial]) | ||
| .order_by("visit_date") | ||
| .values("visit_date")[:1] |
There was a problem hiding this comment.
nit: You can use .first() here instead of the slice
There was a problem hiding this comment.
I tried .first() but subquery here expects a queryset.
pxwxnvermx
reviewed
Oct 14, 2024
sravfeyn
reviewed
Oct 14, 2024
| from commcare_connect.program.models import ManagedOpportunity, Program | ||
|
|
||
|
|
||
| def calculate_safe_percentage(numerator, denominator): |
There was a problem hiding this comment.
It's not worth for this to be a function, may be a private function inside the caller would be better
There was a problem hiding this comment.
I have used this function in PR-402 too.
sravfeyn
reviewed
Oct 14, 2024
| assert annotated_opp.percentage_conversion == 60.0 | ||
|
|
||
| def test_empty_scenario(self): | ||
| opps = get_annotated_managed_opportunity(self.program) |
There was a problem hiding this comment.
You could consider using parametrize, to combine some of the tests like below (not tested). Allows to be more DRY and concise.
@pytest.mark.parametrize(
"visit_statuses, passing_assessments, expected_invited, expected_passing, expected_delivery, expected_conversion",
[
([VisitValidationStatus.pending, VisitValidationStatus.pending, VisitValidationStatus.trial],
[True, True, True], 5, 5, 3, 60.0), # Basic scenario
([], [], 0, 0, 0, 0.0), # Empty scenario
([VisitValidationStatus.pending] * 3, [True] * 3, 1, 1, 1, 100.0), # Multiple visits scenario
([VisitValidationStatus.over_limit, VisitValidationStatus.trial],
[True, True], 2, 2, 0, 0.0), # Excluded statuses
([VisitValidationStatus.pending, VisitValidationStatus.pending],
[False, True], 2, 1, 2, 100.0), # Failed assessments
]
)
def test_scenarios(self, visit_statuses, passing_assessments, expected_invited, expected_passing, expected_delivery, expected_conversion):
for i, visit_status in enumerate(visit_statuses):
self.create_user_with_access(visit_status=visit_status, passed_assessment=passing_assessments[i])
opps = get_annotated_managed_opportunity(self.program)
assert len(opps) == 1
annotated_opp = opps[0]
assert annotated_opp.workers_invited == expected_invited
assert annotated_opp.workers_passing_assessment == expected_passing
assert annotated_opp.workers_starting_delivery == expected_delivery
assert annotated_opp.percentage_conversion == expected_conversion
There was a problem hiding this comment.
Added f87aa02
…rk-manager-funnel-performance
…nnel-performance merge main branch into current branch
…rk-manager-funnel-performance
…mance' into hy/Network-manager-funnel-performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dimagi.atlassian.net/browse/CCCT-479