Payment Accrual Report for Network Managers #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxwxnvermx
changed the title
calellowitz
reviewed
Sep 5, 2024
| @@ -400,6 +401,8 @@ class Payment(models.Model): | |||
| ) | |||
| confirmed = models.BooleanField(default=False) | |||
| confirmation_date = models.DateTimeField(null=True) | |||
| # This is used to indicate Payments made to Network Manager organizations | |||
| organization = models.ForeignKey(Organization, on_delete=models.DO_NOTHING, null=True, blank=True) | |||
There was a problem hiding this comment.
I think this can just be a boolean like org_payment and it would be great to have a constraint to make sure opportnity access is always null when it is True
There was a problem hiding this comment.
Also is this set in this PR or a different one. I couldn't find it.
There was a problem hiding this comment.
this is set in this PR. #387
| "PaymentReportData", ["payment_unit", "approved", "user_payment_accrued", "nm_payment_accrued"] | ||
| ) | ||
| data = [] | ||
| total_paid_users = ( |
There was a problem hiding this comment.
nit: the queries may be cleaner in a helper function like the other big complex tables. I know those were single db queries, but i think its fine to have complex ones like this there too, becuase it separates it from the view code, making the view easier to read.
calellowitz
approved these changes
Sep 12, 2024
hemant10yadav
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket