Copy CCC Global database changes - Version 6 #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added table to global DB for storing ConnectKeyRecords (changed DB version to 6).
|
@damagatchi retest this please |
shubham1g5
reviewed
Aug 16, 2024
There was a problem hiding this comment.
Code Looks ok to me and will let @OrangeAndGreen confirm if it merges all DB changes from Connect.
Also we will need to test the update from current Playstore version to 2.54 after merging this.
Yes, I'm going to raise a separate PR for V7. |
|
@damagatchi retest this please |
3 similar comments
|
@damagatchi retest this please |
|
@damagatchi retest this please |
|
@damagatchi retest this please |
|
@shubham1g5 just an update to the externalizable classes list, can I have your approval again? |
shubham1g5
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to copy Global DB changes that were done as part of the CCC work. The goal with bringing these changes is to ensure a healthy update from that version to production. Changes included here are:
Safety Assurance
Safety story
I believe this is safe as we are only adding a new table to the Global DB that is used by CCC.
cross-request: dimagi/commcare-core#1416