Refactor imports to have file extensions to comply with ESM standards #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
suggested changes
Oct 1, 2024
There was a problem hiding this comment.
👋 Thanks for working on this. A few initial thoughts:
-
The i18n-verify fails to run. It looks like you removed
esm+extenisonlesswhich is great, but you also need to remove all their usages. -
Poking around, I still see some imports that lack extensions. Can you update the eslint config to enforce exntesions, so that we know we've caught everything?
-
I wouldn't have expected you to know this, so not your fault at all, but please could you update the year in the copyright header of all the files you've updated as part of this PR?
MattIPv4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
What issue does this relate to?
This PR resolves #454.
What should this PR do?
All ESM imports in the project have been updated to include proper file extensions (e.g.,
.js) in line with modern ESM standards. The project’spackage.jsonis also updated to mark it as a proper ESM module.package.jsonto set"type": "module".What are the acceptance criteria?
Please review and let me know if any adjustments are needed!