Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burnt area mapping near real-time #510

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Burnt area mapping near real-time #510

merged 7 commits into from
Jun 10, 2024

Conversation

mpho-sadiki
Copy link
Contributor

Proposed changes

New Near real-time burnt area mapping notebook from DEA (https://knowledge.dea.ga.gov.au/notebooks/Real_world_examples/Burnt_area_mapping_near_realtime/)

Checklist (replace [ ] with [x] to check off)

  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended)
  • Include relevant tags in the first notebook cell and re-use tags if possible
  • Ensure appropriate colour schemes have been used to maximise accessibility for vision impairment. Test your images or learn more with Coblis or TPGI
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

Closes issues (optional)

  • Closes Issue #000

@mpho-sadiki mpho-sadiki changed the title Burnt_area_mapping_near_realtime Burnt area mapping near real-time May 23, 2024
Copy link
Contributor

@mickwelli mickwelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice workflow and the default area & time is great!

  • Suspect that EPSG:6399 (Alaska) is meant to be EPSG:6933, I've committed and pushed this change
  • The plot_variable_images() function: I think there are 2 options. 1) Add the function to the deafrica_tools.plotting module or 2) Add an explanation prior to defining the function.
  • Near RT Image Selection: could an explanation be included as to why image 3 was selected in the example case e.g. cloud free and Sentinel; therefore higher resolution than Landsat? Same for baseline image selection

@mpho-sadiki
Copy link
Contributor Author

Thanks Michael. I have added some markdown for the function and the NRT and baseline image selection.

Copy link
Contributor

@mickwelli mickwelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mpho

@mickwelli mickwelli requested a review from lisarebelo June 6, 2024 07:53
Copy link
Contributor

@lisarebelo lisarebelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Mpho, great to have this notebook available. It is well described with a really nice example and useful optional extras.

A couple of minor edits:

  • remove capitalization in the section titles below (and any others, except for satellite names):

Define suitable date ranges for the baseline and Near Real-time Images
Load, Visualise, and Select a Near Real-time image
In this section, edit "change of finding a suitable image" to "chance of finding a suitable image"

@mpho-sadiki
Copy link
Contributor Author

Thank you Mpho, great to have this notebook available. It is well described with a really nice example and useful optional extras.

A couple of minor edits:

  • remove capitalization in the section titles below (and any others, except for satellite names):

Define suitable date ranges for the baseline and Near Real-time Images
Load, Visualise, and Select a Near Real-time image
In this section, edit "change of finding a suitable image" to "chance of finding a suitable image"

Thanks Lisa.

@mpho-sadiki mpho-sadiki merged commit 44de3a3 into main Jun 10, 2024
1 check passed
@mpho-sadiki mpho-sadiki deleted the NRT-Burnt_area branch October 1, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants